Skip to content

Suggest rustup toolchain link #43066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2017
Merged

Suggest rustup toolchain link #43066

merged 1 commit into from
Jul 6, 2017

Conversation

kornelski
Copy link
Contributor

The contributing instructions only explain how to build the compiler, but not how to try it out.

I found rustup toolchain link to be super useful for this, so I think it's good to suggest it.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Mark-Simulacrum
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 5, 2017

📌 Commit deff795 has been approved by Mark-Simulacrum

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 5, 2017
@bors
Copy link
Collaborator

bors commented Jul 6, 2017

🔒 Merge conflict

@kornelski
Copy link
Contributor Author

Rebased

@alexcrichton
Copy link
Member

@bors: r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Jul 6, 2017

📌 Commit 1297b2d has been approved by Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Jul 6, 2017

⌛ Testing commit 1297b2d with merge 54fc9e4...

bors added a commit that referenced this pull request Jul 6, 2017
Suggest rustup toolchain link

The contributing instructions only explain how to build the compiler, but not how to try it out.

I found `rustup toolchain link` to be super useful for this, so I think it's good to suggest it.
@nikomatsakis
Copy link
Contributor

great =)

@bors
Copy link
Collaborator

bors commented Jul 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 54fc9e4 to master...

@bors bors merged commit 1297b2d into rust-lang:master Jul 6, 2017
@kornelski kornelski deleted the patch-1 branch July 7, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants