borrowck::mir::dataflow: ignore unwind edges of empty drops #41148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
added
the
beta-nominated
nagisa
reviewed
Apr 8, 2017
| @@ -74,6 +76,66 @@ impl<'tcx> MirPass<'tcx> for ElaborateDrops { | |||
|
|
|||
| impl Pass for ElaborateDrops {} | |||
|
|
|||
| /// Return the set of basic blocks whose unwind terminators are known | |||
There was a problem hiding this comment.
I find this comment worded somewhat weirdly. What are the “unwind terminators”? Do you mean the branch that comes out from the terminator, maybe?
nagisa
approved these changes
Apr 8, 2017
This avoids creating drop flags in many unnecessary situations. Fixes rust-lang#41110.
|
@bors r=nagisa |
|
📌 Commit 6979798 has been approved by |
|
⌛ Testing commit 6979798 with merge 666e714... |
bors
added a commit
that referenced
this pull request
Apr 8, 2017
borrowck::mir::dataflow: ignore unwind edges of empty drops This avoids creating drop flags in many unnecessary situations. Fixes #41110. r? @nagisa beta-nominating because regression. However, that is merely a small perf regression and codegen changes are always risky, so we might let this slide for 1.17.
|
☀️ Test successful - status-appveyor, status-travis |
|
Decided it is not worth it to backport. |
nikomatsakis
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids creating drop flags in many unnecessary situations.
Fixes #41110.
r? @nagisa
beta-nominating because regression. However, that is merely a small perf regression and codegen changes are always risky, so we might let this slide for 1.17.