First attempt at fixing nightlies #38324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that stable releases produced by rustbuild will succeed in testing as some of the rustdoc tests use unstable features.
This commit updates the gcc-rs dependency to 0.3.40 to pick up a fix for i686 musl where we needed to pass an extra linker flag to get autoconf's detection of executables working correctly.
Git worktrees have this as a file and typically won't work inside docker containers, but that's ok, so instead of just checking for existence check for a directory to see if the git commands will succeed.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 Let's see if we can get this in for tonight |
|
📌 Commit 4d874a1 has been approved by |
|
cc @nrc, a save-analysis change here |
|
This seems more important than the rollup @bors p=20 |
|
⌛ Testing commit 4d874a1 with merge 409f280... |
|
💔 Test failed - auto-linux-64-nopt-t |
We don't need an extra bare tarball, the save-analysis info is already produced with a version/target in the filename.
alexcrichton
force-pushed
the
fix-nightlies
branch
from
4d874a1 to
6cb8bbc
Compare
|
@bors: r+ force |
|
📌 Commit 6cb8bbc has been approved by |
|
⌛ Testing commit 6cb8bbc with merge 1336742... |
bors
added a commit
that referenced
this pull request
Dec 12, 2016
First attempt at fixing nightlies Looks like we've got a whole slew of bugs on our hands, let's try to fix them all at once.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we've got a whole slew of bugs on our hands, let's try to fix them all at once.