Skip to content

Just pass in NodeId to FunctionContext::new instead of looking it up. #34658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2016
Merged

Just pass in NodeId to FunctionContext::new instead of looking it up. #34658

merged 1 commit into from
Jul 7, 2016

Conversation

luqmana
Copy link
Member

@luqmana luqmana commented Jul 5, 2016

Fixes #34592.

@rust-highfive
Copy link
Contributor

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb
Copy link
Member

eddyb commented Jul 5, 2016

Ugh, the things we do for old trans. @bors r+

@bors
Copy link
Collaborator

bors commented Jul 5, 2016

📌 Commit fd3b464 has been approved by eddyb

@alexcrichton
Copy link
Member

Awesome, thanks for the fix @luqmana!

@bors
Copy link
Collaborator

bors commented Jul 7, 2016

⌛ Testing commit fd3b464 with merge a362b94...

@bors
Copy link
Collaborator

bors commented Jul 7, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@arielb1
Copy link
Contributor

arielb1 commented Jul 7, 2016 •
edited
Loading

@bors retry

random timeout

@bors
Copy link
Collaborator

bors commented Jul 7, 2016

⌛ Testing commit fd3b464 with merge 9c1783a...

bors added a commit that referenced this pull request Jul 7, 2016
@bors
Auto merge of #34658 - luqmana:34592-nested_returns, r=eddyb
9c1783a 
Just pass in NodeId to FunctionContext::new instead of looking it up.

Fixes #34592.
@bors
Copy link
Collaborator

bors commented Jul 7, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 9c1783a to master...

@bors bors merged commit fd3b464 into rust-lang:master Jul 7, 2016
@luqmana luqmana deleted the 34592-nested_returns branch July 7, 2016 21:03
@alexcrichton alexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 26, 2016
@alexcrichton
Copy link
Member

Nominating for beta according to this comment: #34592 (comment)

@eddyb eddyb mentioned this pull request Jul 26, 2016
Closed
@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 28, 2016
@nikomatsakis
Copy link
Contributor

Accepted for backport.

@alexcrichton alexcrichton mentioned this pull request Aug 1, 2016
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Aatch Aatch

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@luqmana @rust-highfive @eddyb @bors @alexcrichton @arielb1 @nikomatsakis @brson @Aatch