Fix half of emscripten's failing tests #31532
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| // For targets like MUSL or Emscripten, however, there is no support for | ||
| // dynamic libraries so we just go back to building a normal library. Note, | ||
| // however, that for MUSL if the library is built with `force_host` then | ||
| // it's ok to be a dylib as the host should always support dylibs. |
There was a problem hiding this comment.
why isn't the force_host statement also true for emscripten?
There was a problem hiding this comment.
The comment says if the library is built with force_host then it's ok to be a dylib as the host should always support dylibs, but emscripten doesn't support dynamic libraries at all (the "libraries" are just hidden javascript files).
There was a problem hiding this comment.
yes, but the host can never be emscripten, right? That would mean we'd have a rustc that runs on emscripten.
I think force_host is just for rustc's unit tests when compiling a compiler plugin.
There was a problem hiding this comment.
That would mean we'd have a rustc that runs on emscripten.
Well, why not? 🐷
|
📌 Commit 657f1cf has been approved by |
Before this PR: > test result: FAILED. 2039 passed; 327 failed; 2 ignored; 0 measured After: > test result: FAILED. 2232 passed; 134 failed; 2 ignored; 0 measured r? @brson
Before this PR:
After:
r? @brson