Rename FnKind variants and stop re-exporting them from the visit module.

[Ms2ger]

There is no longer a need for that pattern, since enums are now qualified.

[rust-highfive]

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

[eddyb]

Was this submitted before? I think I've seen this change in some older PR.

[Ms2ger]

I haven't submitted it before, and didn't find one when looking earlier.

[Manishearth]

I actually did it here and then undid it after some discussion

[Manishearth]

We have prefixes for the rest of the AST types (eg TyFoo, ItemFoo, PatFoo), so a Fk prefix here sounds okay.

[Ms2ger]

We should fix the rest too, but that was more than I felt like today.

[Manishearth]

Hmm, that sounds okay.

I prefer TyFoo over Ty::Foo but not that much.

[alexcrichton]

r? @nrc

cc @rust-lang/compiler

[eddyb]

👍 from me - the EnumVariant naming is a historic artifact, I much prefer Enum::Variant.
Sadly, before we get extensible enums with common fields, Expr_::Path will look worse than ExprPath, so we can't just change over the entire AST now.

[nrc]

@bors: r+

[bors]

📌 Commit 2076cdd has been approved by nrc

[bors]

⌛ Testing commit 2076cdd with merge 8f28c9b...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt