Skip to content

Backport new LLVM version check logic to beta #27494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2015

Conversation

barosl
Copy link
Contributor

@barosl barosl commented Aug 3, 2015

This was #27006, and merged to master, but it would be a good idea to backport it to the beta channel since the users may want to compile it directly on their machines.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@alexcrichton
Copy link
Member

Thanks for the PR! Our process for doing this is to tag the original PR with beta-nominated and then the relevant subteam will either accept or reject the PR for backporting. I've done so on the original PR now.

@alexcrichton
Copy link
Member

And after some quick discussion we've decided to accept!

alexcrichton added a commit that referenced this pull request Aug 3, 2015
Backport new LLVM version check logic to beta
@alexcrichton alexcrichton merged commit 0a07d8b into rust-lang:beta Aug 3, 2015
@barosl
Copy link
Contributor Author

barosl commented Aug 3, 2015

Ah, I was being too hasty. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants