Skip to content

Link to rustdoc page in the Rust book directly #22049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2015

Conversation

caspark
Copy link
Contributor

@caspark caspark commented Feb 7, 2015

No point sending people to a page which just says "this is now part of
the Rust book" (that page being http://doc.rust-lang.org/rustdoc.html).

No point sending people to a page which just says "this is now part of
the Rust book".
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

Thank you!

@steveklabnik
Copy link
Member

@bors: r+ 4038694 rollup

@bors
Copy link
Collaborator

bors commented Feb 8, 2015

⌛ Testing commit 4038694 with merge 1f34e21...

@bors
Copy link
Collaborator

bors commented Feb 8, 2015

💔 Test failed - auto-mac-32-opt

@Manishearth
Copy link
Member


run doc-trpl-compound-data-types [i686-apple-darwin]

running 18 tests
test _14 ... ignored
test _1 ... FAILED
test _13 ... ok
test _10 ... ok
test _12 ... ok
test _15 ... ok
test _0 ... ok
test _11 ... ok
test _16 ... ok
test _3 ... ok
test _17 ... ok
test _6 ... ok
test _5 ... ok
test _2 ... ok
test _4 ... ok
test _8 ... ok
test _7 ... ok
test _9 ... ok

failures:

---- _1 stdout ----
    error: could not exec the linker `cc`: unknown error
error: aborting due to previous error
thread '_1' panicked at 'Box<Any>', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/libsyntax/diagnostic.rs:151

Looks like an intermittent?

kmcallister added a commit to kmcallister/rust that referenced this pull request Feb 8, 2015
…eklabnik

No point sending people to a page which just says "this is now part of
the Rust book" (that page being http://doc.rust-lang.org/rustdoc.html).
@caspark
Copy link
Contributor Author

caspark commented Feb 9, 2015

Given this PR only changes docs (without tests), I think that failure must be unrelated to this PR.

@steveklabnik
Copy link
Member

Yup, not your fault.

@alexcrichton
Copy link
Member

@bors: retry

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 10, 2015
…eklabnik

No point sending people to a page which just says "this is now part of
the Rust book" (that page being http://doc.rust-lang.org/rustdoc.html).
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Feb 10, 2015
No point sending people to a page which just says "this is now part of
the Rust book" (that page being http://doc.rust-lang.org/rustdoc.html).
@bors bors merged commit 4038694 into rust-lang:master Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants