Do not propose suggestions for idents without case #21749
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
I personally don’t think that basically disallowing any identifier that has no lowercase equivalent is a good idea. I’ve opened PR #21765 as an alternative to this one that changes |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 30, 2015
An alternative to rust-lang#21749. This also refactors the naming lint code a little bit and slightly rephrases some warnings (`uppercase` → `upper case`). Closes rust-lang#21735.
|
Closing since the alternative was merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible fixes for #21735
Be sure to read the issue and comments before r+.