Use unsigned comparison operators for unsigned SIMD types. #21720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ 5487422 |
| @@ -623,7 +623,7 @@ pub fn compare_simd_types<'blk, 'tcx>( | |||
| size: uint, | |||
| op: ast::BinOp) | |||
| -> ValueRef { | |||
| match t.sty { | |||
| let cmp = match t.sty { | |||
There was a problem hiding this comment.
Nice! I did something similar in my branch, though I had all the matching in another function and only needed the signedness from this one.
Previously comparisons of SIMD types were always signed, even unsigned comparisons, meaning 0xFFFF_FFFF_u32 < 0 inside a SIMD vector. Fixes rust-lang#21719.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 30, 2015
Previously comparisons of SIMD types were always signed, even unsigned comparisons, meaning 0xFFFF_FFFF_u32 < 0 inside a SIMD vector. Fixes rust-lang#21719.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously comparisons of SIMD types were always signed, even unsigned
comparisons, meaning 0xFFFF_FFFF_u32 < 0 inside a SIMD vector.
Fixes #21719.