Remove (more) dependencies on TypeContents #20159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jroesch |
|
Looks good to me. This appears to resolve the earlier issues I was having with TypeContents and where clauses. |
|
r=me with the various nits fixed |
nikomatsakis
force-pushed
the
die-typecontents-die
branch
from
6da4075 to
e9bc806
Compare
nikomatsakis
force-pushed
the
die-typecontents-die
branch
from
e9bc806 to
a4040de
Compare
types are always known and hence the ParameterEnvironment is not necessary. For other `Sized` queries, use the trait infrastructure just like `Copy`.
nikomatsakis
force-pushed
the
die-typecontents-die
branch
from
a4040de to
250225d
Compare
|
@brson @alexcrichton any idea what this is? (from win32 bot) |
|
Sadly yes, that means that the previous instance of the program never actually died and will prevent all future test runs on the bots from succeeding. The only fix I know of is to remote into the bot and kill the process manually (should be better now). |
|
Closing in favor of #20307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use
TypeContentsto determine whether types are sized. This is not good becauseTypeContentscannot take the parameter environment into account and thus cannot handle where clauses.This patch removes most of those uses and instead uses the trait resolution infrastructure. This means that we can handle context-dependent where clauses.
TypeContentsis still used in trans (possibly this should be removed in a later refactor, actually).r? @nick29581