API docs/examples for std::slice #16244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jasonthompson
commented
Aug 4, 2014
jasonthompson
commented
- API example for move_from in MutableVectorAllocating
- API doc/example for next() in Permutations
- API doc/example for permutations() in ImmutableCloneableVector
| /// for p in perms { | ||
| /// println!("{}", p); | ||
| /// } | ||
| /// ``` |
There was a problem hiding this comment.
Because this is a trait method, this won't actually show up in rustdoc. Could you add this documentation to the trait instead?
- API example for move_from in MutableVectorAllocating - API doc/example for next() in Permutations - API doc/example for permutations() in ImmutableCloneableVector
- Moved examples for permutations and next into trait definition.
|
Closing in favor of #16417 |
bors
added a commit
that referenced
this pull request
Aug 12, 2014
- Moved examples for permutations and next into trait definition as comments on pull request #16244. - Fixed (hopefully) issue with erronious commit of changes to src/llvm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.