Spelling & minor span fix #14357
Merged
Spelling & minor span fix #14357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The position of the .bump call (before extracting the span fields) was causing a doc-comment to have the span of the next token, not itself.
|
(I've manually verified the span thing, but I don't know how to write a test for it.) |
bors
added a commit
that referenced
this pull request
May 23, 2014
The span on a inner doc-comment would point to the next token, e.g. the span for the `a` line points to the `b` line, and the span of `b` points to the `fn`.
```rust
//! a
//! b
fn bar() {}
```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 20, 2023
fix: Don't pass feature flags to rustc private crates metadata invocation Fixes rust-lang/rust-analyzer#14327 Better error reporting I'll do in a follow up
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 3, 2025
…ension_comparions` (rust-lang#14358) close rust-lang#14357 changelog: [`case_sensitive_file_extension_comparisons`]: suggest `is_some_and` to suppress other lint warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The span on a inner doc-comment would point to the next token, e.g. the span for the
aline points to thebline, and the span ofbpoints to thefn.