-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add bors environment to CI #141323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kobzol
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
Kobzol:bors-environment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add bors environment to CI #141323
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
f7406db
to
05766f2
Compare
Ok I think that we can merge this as-is, it shouldn't break the current setup, but at the same time it should provide environment secrets to the |
please comment the code to explain why we are doing this 👍 |
This will be used to access secrets once we move off rust-lang-ci.
Good idea, added a comment. |
@bors r+ |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 22, 2025
Add bors environment to CI This will be used to access secrets once we move off rust-lang-ci. The PR configures the environment: - Only for `rust-lang/rust`, so that it doesn't affect `rust-lang-ci/rust` before we switch (we can remove this condition later, but the environment likely won't work for forks anyway, so we might as well just keep it to make fork CI work) - Only for the `try`/`auto` branches, so that PR CI still works. Context: rust-lang/infra-team#188 r? `@marcoieni`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#140431 (dont handle bool transmute) - rust-lang#140868 (rustdoc: Fix links with inline code in trait impl docs) - rust-lang#141323 (Add bors environment to CI) - rust-lang#141337 (bump stdarch) - rust-lang#141364 (rustdoc-json: Remove false docs and add test for inline attribute) - rust-lang#141370 (add doc alias `replace_first` for `str::replacen`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used to access secrets once we move off rust-lang-ci. The PR configures the environment:
rust-lang/rust
, so that it doesn't affectrust-lang-ci/rust
before we switch (we can remove this condition later, but the environment likely won't work for forks anyway, so we might as well just keep it to make fork CI work)try
/auto
branches, so that PR CI still works.Context: rust-lang/infra-team#188
r? @marcoieni