Skip to content

Add method to retrieve body of closure in stable-mir #141307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add method to retrieve body of closure in stable-mir #141307

wants to merge 1 commit into from
+96 −0

Conversation

b-naber
Copy link
Contributor

@b-naber b-naber commented May 20, 2025

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 20, 2025
celinval
celinval reviewed May 21, 2025
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! If it's not too much work, can you please add a test for a closure that takes a generic argument?

compiler/rustc_smir/src/stable_mir/ty.rs
@@ -742,6 +742,12 @@ crate_def! {
pub ClosureDef;
}

impl ClosureDef {
pub fn body(&self) -> Option<Body> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celinval celinval celinval left review comments

Assignees

@celinval celinval

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an Instance resolve for the closure function itself
3 participants
@b-naber @celinval @rustbot