Return value of coroutine_layout fn changed to Result with LayoutError #140926
+25
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
RalfJung
reviewed
May 11, 2025
compiler/rustc_middle/src/ty/sty.rs
Outdated
| @@ -100,10 +102,11 @@ impl<'tcx> ty::CoroutineArgs<TyCtxt<'tcx>> { | |||
| #[inline] | |||
| fn discriminants( | |||
| self, | |||
| ty: Ty<'tcx>, | |||
There was a problem hiding this comment.
The doc comment should explain the meaning of the new argument and how it relates to self.
There was a problem hiding this comment.
Since it is only used for the Unknown layout error, reconstruct it with Ty::new_coroutine maybe?
azhogin
force-pushed
the
azhogin/async-drop-coroutine-layout-returns-layout-error
branch
from
9ce3d8a to
ba80d82
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue of #140902:
coroutine_layoutfn is now returnsResultwithLayoutErrorto have consistent error withlayout_of_uncached.async_drop_coroutine_layoutfn is now returnLayoutError::TooGenericin case of not-fully-specializedasync_drop_in_place<T>::{closure}coroutine.