-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix download of GCC from CI on non-nightly channels #140901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than one question.
let filename = format!("gcc-nightly-{}.tar.xz", self.build.triple); | ||
let version = self.artifact_version_part(gcc_sha); | ||
let filename = format!("gcc-{version}-{}.tar.xz", self.build.triple); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work fine on stable channels?
rust/src/bootstrap/src/core/config/config.rs
Lines 2704 to 2709 in b105556
match channel.as_str() { | |
"stable" => version, | |
"beta" => channel, | |
"nightly" => channel, | |
other => unreachable!("{:?} is not recognized as a valid channel", other), | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use the exact same code for downloading LLVM and CI rustc, and the GCC dist component should produce the dist artifacts on all channels, so I think it should. But as usually, it's hard to be sure until we try.. 😆
@bors r+ p=1 |
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing dbab4e1 (parent) -> 7b84c9e (this PR) Test differencesNo test diffs found Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 7b84c9e9ca4b9c68c888b77762c31e180ee7af45 --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (7b84c9e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 0.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -0.6%, secondary 3.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 772.568s -> 771.777s (-0.10%) |
Fixes the download failure on beta (#140897 (comment)).
r? @onur-ozkan