Skip to content

Make t letter looks like lowercase rather than uppercase #140865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025

Conversation

Kivooeo
Copy link
Contributor

@Kivooeo Kivooeo commented May 9, 2025

randomly noticed that, took opportunity to fix :D
it was looks like "RusT" now fixed to "Rust"
r? @jieyouxu
before

now

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 9, 2025
@Noratrieb Noratrieb assigned Noratrieb and unassigned jieyouxu May 9, 2025
@Noratrieb
Copy link
Member

I think the resolution is too low to properly convey details like the line on the u or the bottom of the t. I think removing those and making both letter symmetric would look better. The top of the t does look much better now

@Kivooeo
Copy link
Contributor Author

Kivooeo commented May 9, 2025

@Noratrieb i was thinking about "u", and it's all started from that i wanted to remove this thing in bottom right corner (i have no idea how this called)
but i get into situation where "u" started looks like "v'
is that only me or you also see v here
image

also about "t" do you think it looks better?
image

@Noratrieb
Copy link
Member

how about both sides for the u? I do like the new t more, but I'm not entirely sure about it

@Kivooeo
Copy link
Contributor Author

Kivooeo commented May 9, 2025

yeah, now its not looks like "v" for me
image
about "t", new one is without that thing at bottom right, right?

@Noratrieb
Copy link
Member

yeah. although looking at it again I think your t with the bump at the bottom does look pretty good.

thanks for this very important improvement 🚀

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 10, 2025

📌 Commit 4314d19 has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2025
Rollup of 7 pull requests

Successful merges:

 - rust-lang#140792 (Use intrinsics for `{f16,f32,f64,f128}::{minimum,maximum}` operations)
 - rust-lang#140795 (Prefer to suggest stable candidates rather than unstable ones)
 - rust-lang#140865 (Make t letter looks like lowercase rather than uppercase)
 - rust-lang#140878 (Two expand-related cleanups)
 - rust-lang#140882 (Split duration_constructors to get non-controversial constructors out)
 - rust-lang#140886 (Update deps of bootstrap for Cygwin)
 - rust-lang#140903 (test intrinsic fallback bodies with Miri)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 53f88f9 into rust-lang:master May 11, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 11, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2025
Rollup merge of rust-lang#140865 - Kivooeo:9th, r=Noratrieb

Make t letter looks like lowercase rather than uppercase

randomly noticed that, took opportunity to fix :D
it was looks like "RusT" now fixed to "Rust"
r? `@jieyouxu`
before
<img src="https://github.com/user-attachments/assets/1ff19891-2e7b-4633-897d-2b2635aff9c6" width="65%" />
now
<img src="https://github.com/user-attachments/assets/d577a2af-6755-411b-8050-2556f0f12e75" width="65%" />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants