Remove mono item collection strategy override from -Zprint-mono-items

[tmiasko]

Previously -Zprint-mono-items would override the mono item collection
strategy. When debugging one doesn't want to change the behaviour, so
this was counter productive. Additionally, the produced behaviour was
artificial and might never arise without using the option in the first
place (-Zprint-mono-items=eager without -Clink-dead-code). Finally,
the option was incorrectly marked as UNTRACKED.

Resolve those issues, by turning -Zprint-mono-items into a boolean
flag that prints results of mono item collection without changing the
behaviour of mono item collection.

For codegen-units test incorporate -Zprint-mono-items flag directly
into compiletest tool.

Test changes are mechanical. -Zprint-mono-items=lazy was removed
without additional changes, and -Zprint-mono-items=eager was turned
into -Clink-dead-code. Linking dead code disables internalization, so
tests have been updated accordingly.

[rustbot]

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in src/tools/compiletest

cc @jieyouxu

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

[rustbot]

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

[jieyouxu]

r? @saethlin (as I imagine you'd be most familiar with this)

[compiler-errors]

I like this a lot!

[saethlin]

This is so nice. Thank you.

@bors r+

[bors]

📌 Commit 8c8225a has been approved by saethlin

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8c8225a with merge 6812af9...

[bors]

☀️ Test successful - checks-actions
Approved by: saethlin
Pushing 6812af9 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ce7e97f (parent) -> 6812af9 (this PR)

Test differences

Show 9 test diffs

Stage 1

• errors::verify_monomorphize_abi_error_disabled_vector_type_7: [missing] -> pass (J0)
• errors::verify_monomorphize_abi_error_disabled_vector_type_8: pass -> [missing] (J0)
• errors::verify_monomorphize_abi_error_unsupported_vector_type_8: [missing] -> pass (J0)
• errors::verify_monomorphize_abi_error_unsupported_vector_type_9: pass -> [missing] (J0)
• errors::verify_monomorphize_abi_required_target_feature_10: pass -> [missing] (J0)
• errors::verify_monomorphize_abi_required_target_feature_9: [missing] -> pass (J0)
• errors::verify_monomorphize_unknown_cgu_collection_mode_7: pass -> [missing] (J0)
• errors::verify_monomorphize_wasm_c_abi_transition_10: [missing] -> pass (J0)
• errors::verify_monomorphize_wasm_c_abi_transition_11: pass -> [missing] (J0)

Job group index

• J0: aarch64-apple, aarch64-gnu, i686-gnu-2, i686-gnu-nopt-2, i686-msvc-2, x86_64-apple-1, x86_64-gnu, x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-3, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-2, x86_64-msvc-2

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 6812af9821c86b344c6d9e3584681f8589da6801 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. x86_64-apple-1: 5994.6s -> 7495.9s (25.0%)
2. dist-arm-linux: 4749.3s -> 5483.4s (15.5%)
3. x86_64-msvc-ext3: 8715.0s -> 7637.3s (-12.4%)
4. aarch64-apple: 4096.9s -> 3830.7s (-6.5%)
5. dist-x86_64-apple: 7941.0s -> 7474.2s (-5.9%)
6. dist-android: 2525.4s -> 2660.8s (5.4%)
7. aarch64-gnu: 6246.0s -> 6536.8s (4.7%)
8. dist-aarch64-apple: 5176.1s -> 4941.3s (-4.5%)
9. dist-x86_64-msvc: 6273.6s -> 6012.0s (-4.2%)
10. dist-i586-gnu-i586-i686-musl: 5279.0s -> 5092.7s (-3.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (6812af9): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.6%	[-1.6%, -1.6%]	1

Max RSS (memory usage)

Results (primary -0.7%, secondary -3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.5%, 1.7%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.3%	[-2.6%, -0.4%]	6
Improvements ✅ (secondary)	-3.3%	[-5.3%, -1.7%]	5
All ❌✅ (primary)	-0.7%	[-2.6%, 1.7%]	8

Cycles

Results (primary 2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.3%	[2.3%, 2.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.51s -> 772.534s (0.00%)
Artifact size: 365.40 MiB -> 365.43 MiB (0.01%)