Skip to content

build_helper: temporarily swallow remove dir failure #140119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

build_helper: temporarily swallow remove dir failure #140119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/build_helper/src/fs/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ where

pub fn remove_and_create_dir_all<P: AsRef<Path>>(path: P) -> io::Result<()> {
let path = path.as_ref();
recursive_remove(path)?;
// FIXME(#134351): for reasons that are not clear yet, `tests/mir-opt/strip_debuginfo.rs`
// triggers various permission denied and dir not empty failures too frequently. Temporarily
// swallow the remove dir failure to make CI failure rate tolerable, but this is mostly likely
// masking a genuine bug, possibly some kind of race condition.
let _ = recursive_remove(path);
fs::create_dir_all(path)
}
Loading