rustdoc: Make going back in browser history work after typing a search term

[noamraph]

Currently, in both chrome and firefox, if I type something in the search box in the reference docs I get immediately the search results. That's great. However, if I want to go back to the doc I was reading and try to press the back button, I am immediately forwarded again to the search results. This is caused by the fact that the search term is (deliberately) left in the search box, and the search() function is called as if I typed the search term again.
I disabled calling the search() function if there's no search term in the URL, and now it seems to work fine.

I hope I'm sending the pull request correctly - I'm not really used to git and github.

[lilyball]

Why is the search term deliberately left in the search box? I would expect it to be removed. If there's a search term in the search box, I should be seeing the search results.

[noamraph]

I don't really know, but a comment says "don't empty the bar if there's nothing there."
There's something nice about the search term being left in the search box because it reminds what was searched. I actually don't see a problem with it, since it seems that the search results only appear if the search term is being edited.

[lilyball]

There's something nice about the search term being left in the search box because it reminds what was searched

That actually sounds like the complete opposite of correct behavior. If I want to see what I searched for I'll just hit Forward again. But the way the UI works right now, if there's something in the search field, then I should be seeing search results.

I see the comment you're referring to, but I think it's wrong. That comment should be removed and the code should be updated to clear the search box if there's no query parameter.

[noamraph]

That's actually pretty easy - the "if" around $('.search-input').val(params.search); should just be removed. What should I do now? Should I create a new branch and a new pull request?

[lilyball]

Make your changes, amend the original commit (git commit --amend can do it, or you can use git rebase --interactive to squash them), and force-push back to the same branch. That will update this PR with your new code. You should then comment on the PR so we know you force-pushed (GitHub doesn't send emails for force pushes).

[noamraph]

Ok, I did exactly that.