Remove needless returns detected by clippy in the compiler #130114
Conversation
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
O-unix
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
@eduardosm can you split off the library parts into their own PR? |
eduardosm
changed the title
|
Done, libraries part here |
eduardosm
changed the title
|
It's not obvious that these are all harmless changes - sometimes the explicit return expresses intent, so it should be preserved to account for future possible refactorings even if it does not make a difference right now.
|
|
I undid some of the changes, trying to keep only the most obvious ones. |
| @@ -336,7 +336,7 @@ impl<'tcx, M: Machine<'tcx>> InterpCx<'tcx, M> { | |||
| return true; | |||
| } | |||
| } | |||
| return false; | |||
There was a problem hiding this comment.
IMO it is nicer, for symmetry with the return just a few lines above, to use return here.
That's exactly why I don't like just forcing such clippy lints over the entire codebase...
There was a problem hiding this comment.
I have exactly the opposite opinion. I like the consistency that tools like clippy encourage, and in this case I think the change makes the "early return" and "default/fallthrough" visually distinct, which I find easier to read.
There was a problem hiding this comment.
The last two returns here are not distinct in a meaningful sense, so it is not a good idea to make them visually distinct.
There was a problem hiding this comment.
I agree with @saethlin. I think it's just plain odd to have return value; at the end of a block when it's not suggesting exceptional control flow.
I think it's actually very odd that miri has allow(clippy::needless_return) on its codebase, but for the rest of the compiler I think this should be fixed.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Oops, closed the wrong PR !! Meant to close mine which is a duplicate :) |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
No description provided.