Skip to content

[PERF-EXPERIMENT] Add second span to a span #118517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

petrochenkov
Copy link
Contributor

cc #95580

@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2023

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 1, 2023
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 1, 2023
@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 1, 2023
@bors
Copy link
Collaborator

bors commented Dec 1, 2023

⌛ Trying commit b906c40 with merge e5e928e...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2023
[PERF-EXPERIMENT] Add second span to a span

cc rust-lang#95580
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   --> src/tools/clippy/clippy_utils/src/macros.rs:433:9
    |
433 |       let SpanData {
    |  _________^
434 | |         lo,
435 | |         hi,
436 | |         ctxt,
437 | |         parent: _,
438 | |     } = target.expr.span.data();
    | |_____^ missing field `span2`
help: include the missing field in the pattern
    |
    |
437 |         parent: _, span2 } = target.expr.span.data();
help: if you don't care about this missing field, you can explicitly ignore it
    |
    |
437 |         parent: _, .. } = target.expr.span.data();

    Checking levenshtein v1.0.5
error[E0063]: missing field `span2` in initializer of `SpanData`
   --> src/tools/clippy/clippy_utils/src/source.rs:484:5

@bors
Copy link
Collaborator

bors commented Dec 1, 2023

☀️ Try build successful - checks-actions
Build commit: e5e928e (e5e928e2b78547d491ae9f6e6685811ec3048beb)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e5e928e): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.2% [0.1%, 0.3%] 15
Regressions ❌
(secondary)
0.2% [0.2%, 0.3%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.4% [-0.4%, -0.4%] 1
All ❌✅ (primary) 0.2% [0.1%, 0.3%] 15

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.4% [0.4%, 2.0%] 7
Regressions ❌
(secondary)
3.7% [2.0%, 5.5%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.7% [-2.7%, -2.7%] 1
All ❌✅ (primary) 1.4% [0.4%, 2.0%] 7

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.0%, 3.2%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.427s -> 673.025s (0.09%)
Artifact size: 313.37 MiB -> 313.40 MiB (0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 2, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 6, 2023
[PERF-EXPERIMENT] Add second span to TokenTree

cc rust-lang#118517
@petrochenkov petrochenkov deleted the span2 branch February 22, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants