Implement minmax function #11767
Closed
Implement minmax function #11767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// `OneElement(x)` is returned if the iterator `minmax` operates on has exactly one element; | ||
| /// `x` takes the value of that argument. | ||
| /// Otherwise, `MinMax(x, y)` is returned, where x <= y; | ||
| /// x == y happens if and only if the vector has more than one elements and all elements are equal. |
There was a problem hiding this comment.
Should be "more than one element" not "elements".
|
Embarrassingly, there are some problems with the PR that I forgot to fix when I migrate the code over. Fixing right now. |
|
After a few git problems, I got the problem fixed. Should be ready for review now. |
|
Could you rebase this without all those merge commits? |
|
I have apparently completely messed up my fork. Will fix and send another PR. Sorry for the confusion, I'm a git newbie :( |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 16, 2023
…ons-ext-notes, r=blyxyas Add type details to unnecessary_fallible_conversions note fixes: rust-lang#11753 changelog: [`unnecessary_fallible_conversions`]: add type details to lint note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5268