libnative: Implement get_host_addresses. #11732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // cannot give tcp/ip permission without help of apk | ||
| #[cfg(test, not(target_os="android"))] | ||
| mod test { |
There was a problem hiding this comment.
Could you actually add these tests to io::net::addrinfo instead? That way you can use the iotest! macro and seamlessly test on libnative and libgreen.
There was a problem hiding this comment.
Looks like there's also a test that should be converted to iotest! in that module.
|
Nice work, thanks for doing this! |
bors
added a commit
that referenced
this pull request
Jan 24, 2014
The last bit I needed to be able to use libnative :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last bit I needed to be able to use libnative :P