update Miri #114560
Merged
update Miri #114560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic sync from rustc
refactor tests/utils a bit, and move some FS functions there
…883, r=RalfJung Rewrite miri script in rust This is a sketch of a rewrite of miri script in Rust. It does not include changes made in rust-lang/miri#2908 yet. Environment variables are not properly propagated yet, which is something I plan to address. This PR is mostly a heads-up about the ongoing effort and it's state. It's definitely not the cleanest code I've seen in my life, but my first goal was feature/interface parity. I will iterate on it a bit before marking it as ready. I wonder though how this should be integrated/tested. Are you aware of anyone using `./miri` in their scripts? I guess we should keep existing `miri` script in place and let it run miri-script package directly? CI should probably `cargo check` this package as well. Fixes rust-lang#2883
add some interesting tests for alignment corner cases `strange_enum_discriminant_offset` example found in rust-lang#53998.
fix oversight from new miri-script
Automatic sync from rustc
…_to_const_raw test in TB
miri-script: simplify flag computation a bit
add some SB and TB tests Also I realized the `direct_mut_to_const_raw` test can be enabled in TB, so let's do that.
… some custom debugging code
miri-script and cargo-miri cleanups At least in an initial test, `cmd!(Shell::new()?, "env")` does show the full environment. Let's see what CI says. `@osiewicz` why did you add this code to forward the host environment?
…fJung tree borrows: consider some retags as writes for the purpose of data races Turns out not all retags can be freely reordered. Those that cannot should be considered writes for the data race model, to aid with optimizations. Only the last commit is the actual change; the ones before that are some refactoring I couldn't stop myself from doing.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
The Miri subtree was changed cc @rust-lang/miri |
|
@bors r+ p=1 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit d1174a9 with merge 970ee96bc907da97e334acecaa618e60337a58ac... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry armhf-gnu: client.read_exact(&mut header) failed with Connection reset by peer (os error 104) |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (adb15a2): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 652.367s -> 652.069s (-0.05%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.