Skip to content

Stable MIR: Add basic MIR body datastructures #109224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 16, 2023

At this point it will panic on most useful MIR, but you can do basic assignments

r? @pnkfelix

@rustbot
Copy link
Collaborator

rustbot commented Mar 16, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 16, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval

@rustbot

This comment was marked as duplicate.

@rust-log-analyzer

This comment was marked as outdated.

@pnkfelix
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 29, 2023

📌 Commit 480e042 has been approved by pnkfelix

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2023
@bors
Copy link
Collaborator

bors commented Mar 30, 2023

⌛ Testing commit 480e042 with merge 82bfda8...

@bors
Copy link
Collaborator

bors commented Mar 30, 2023

☀️ Test successful - checks-actions
Approved by: pnkfelix
Pushing 82bfda8 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Mar 30, 2023

☀️ Test successful - checks-actions
Approved by: pnkfelix
Pushing 82bfda8 to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels Mar 30, 2023
@bors bors merged commit 82bfda8 into rust-lang:master Mar 30, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 30, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (82bfda8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.3% [-3.3%, -3.3%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.3% [-3.3%, 2.6%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

@oli-obk oli-obk deleted the smir branch March 30, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants