Skip to content

Stop building jemalloc once per stage #7002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bstrie opened this issue Jun 7, 2013 · 2 comments · Fixed by #9772
Closed

Stop building jemalloc once per stage #7002

bstrie opened this issue Jun 7, 2013 · 2 comments · Fixed by #9772

Comments

@bstrie
Copy link
Contributor

bstrie commented Jun 7, 2013 

18:57 < bstrie> cmr: it looks like jemalloc gets built at every stage, rather 
                than once ever. surely that's not intentional?
18:57 < strcat> bstrie: the runtime is built at every stage now
18:57 < strcat> it wasn't when I made that
18:58 < bstrie> strcat: surely there's no reason we *have* to build jemalloc at 
                every stage, right?
18:58 < strcat> there isn't really a reason but it means making another 
                top-level directory for it
18:59 < strcat> where do we put libuv?
18:59 < cmr> Would an extern or thirdparty dir make sense?
18:59 < bstrie> I think handling it the same way as libuv would be ideal
18:59 < bstrie> for the sake of consistency
@alexcrichton
Copy link
Member

Blocked on #7217

@huonw
Copy link
Member

huonw commented Sep 23, 2013

Triage: jemalloc is renabled, so this is is again relevant, and the logs indicate that we're building (and configuring!) jemalloc anew at each stage.

@alexcrichton alexcrichton mentioned this issue Oct 8, 2013
Merged
bors added a commit that referenced this issue Oct 8, 2013
@bors
auto merge of #9772 : alexcrichton/rust/buildsystem, r=thestinger
6c2cdb3 
Reorganize the makefiles to stop building these once per stage because there's
no need to do this at all.

Closes #7002
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 8, 2021
@bors
Auto merge of rust-lang#7002 - mgacek8:issue6983_wrong_self_conventio…
38b1fd0 
…n_inside_trait_impls, r=phansch

wrong_self_convention: fix FP inside trait impl for `to_*` method taking `&self`

fixes rust-lang#6983
changelog: `wrong_self_convention`: fix FP inside trait impl for `to_*` method taking `&self`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build libuv/jemalloc only once (not per stage) alexcrichton/rust
3 participants
@alexcrichton @bstrie @huonw