Export uv functions from rustrt, remove wrappers #5429
Comments
|
So is uv going to be in core then? #4956 |
|
The long-term plan is for uv to be in its own crate and imported as the default I/O implementation, not in core. |
|
Adding |
|
Adding |
brson
added a commit
to brson/rust
that referenced
this issue
May 8, 2013
This removes almost all of the simple wrappers from rust_uv.cpp. For some reason uv_getaddrinfo and uv_freeaddrinfo still can't be removed.
|
|
|
Do we have any idea what the root cause is here? |
|
I don't know why this is on a milestone. Removing. |
|
I did this awhile back, libuv is statically linked, exporting all those functions, and I removed all wrappers that weren't just there to access fields of structs we don't know the layout of in rust. |
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this issue
May 2, 2020
…ip1995 Use assoc int and float consts instead of module level ones changelog: Recommend primitive type associated constants instead of module level constants In Rust 1.43 integer and float primitive types will have a number of new associated constants. For example `MAX`, `MIN` and a number of constants related to the machine representation of floats. rust-lang#68952 These new constants are preferred over the module level constants in `{core,std}::{f*, u*, i*}`. I have in the last few days made sure that the documentation in the main rust repository uses the new constants in every place I could find (rust-lang#69860, rust-lang#70782). So the next step is naturally to make the linter recommend the new constants as well. This PR only changes two lints. There are more. But I did not want the PR to be too big. And since I have not contributed to clippy before it felt saner to start with a small PR so I see if there are any quirks. More will come later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is some linkage issue causing the uv API to not be exported from rustrt, and as a result we've accumulated a bunch of functions prefixed with
rust_uvthat do nothing but wrap them. Figure out how to make the uv API public and delete all these functions.The text was updated successfully, but these errors were encountered: