Raise the 78-column tidy limit #5274
Comments
|
+1. There is no modern machine has problem to show 100~120 columns. |
|
I like that there's a line length limit, but I do tentatively agree that 78 columns is too few. My current terminal is 116 characters, for reference. This takes up half my screen. And let's find out how long you can make a line on Github without scrolling: 100 characters looks to be the exact limit (in my font, at least). |
|
For more around-the-web polls, Gist shows 104 characters without scrolling: https://gist.github.com/bstrie/5116988 and Reddit shows 110: http://www.reddit.com/r/sandbox/comments/19wpoy/testing_characters/c8s0rcx Your fonts may differ, though I'd be surprised if they differ by much. |
|
For reference, the Spidermonkey team uses 100. The nice thing about this limit is that by the time it is exceeded, the lines just feel too long. In contrast, I often run up against the 78 character limit but the lines don't feel long at all. |
|
I vote for increasing it to 100. |
|
+1 for 100. Still allows leeway for people who are wired to code at 78 columns. |
|
discussed at weekly meeting, consensus (with a couple sad faces) was to raise to 100. |
|
Closing, fixed in #5340 |
…ibility of the module that contains them Closes rust-lang#5274.
Lint for `pub(crate)` items that are not crate visible due to the visibility of the module that contains them changelog: Add `redundant_pub_crate` lint Closes rust-lang#5274.
I have been trying to merge a large patch and have hundreds of long lines warnings. Eliminating them is making the code look worse. There are other modules in the code base that have this problem as well. I don't think the limit gives us any significant benefits and recommend raising it to 100 columns.
The text was updated successfully, but these errors were encountered: