Skip to content

Export pipe traits (GenericChan, etc.) from prelude by default #5045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Feb 20, 2013 · 2 comments
Closed

Export pipe traits (GenericChan, etc.) from prelude by default #5045

brson opened this issue Feb 20, 2013 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Feb 20, 2013

In #4867 we removed GenericChan and GenericPort from the prelude. I now think this was a mistake, since these are the traits that provide send and recv. Maybe GenericChan, GenericPort, GenericSmartChan and Peekable should all be imported by default.
@brson brson mentioned this issue Mar 9, 2013
Closed
@brson
Copy link
Contributor Author

brson commented Mar 9, 2013

These names should also be considered more carefully at some point

@pcwalton
Copy link
Contributor

Looks done.

bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5046 - JohnTitor:order-nonminimal-bool, r=fli…
0964b8d 
…p1995

Keep the ordering in `nonminimal_bool` lint

I believe it shouldn't cause any regression but feel free to let me know if you have a doubtful example.
Also, splits up `booleans` ui test.

Fixes rust-lang#5045

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brson @pcwalton