-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Extend tidy license check to remaining source code #4534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Another thing to add to the tidy license checking: checking the copyright year that appears at the top of the file. Graydon said this should be a list or range of years in which significant changes were made. So many files will have to change from 2012 (as they are now) to 2011-2013 or some other such thing. |
I think this is done now, no? |
@graydon It seems like it's not -- tidy isn't being run on tests (so that tests aren't required to have the 100-column limit), but tidy calls the license script. So the tests aren't being checked for licenses at all. Unless I'm missing something. |
Nominating for milestone 5, production-ready -- we probably have to bite the bullet and do this sooner than later. |
Accepted for milestone 5 |
Once #12055 lands, are there any other areas that need checking? Right now it appears we run tidy on:
|
P-low. This issue is almost done, according to @brson. |
@dguenther The only remaining missing licenses I'm aware of are in src/doc. There are some scripts there that should have the license block, but more importantly the docs themselves do not have a license declared but should (#12069). I'd consider the doc licenses to be a separate issue, so once the scripts are all covered this issue is done. |
This PR extends the tidy formatting check to rust files in the test folder. To facilitate this, a few flags were added to tidy: * `xfail-tidy-cr` - Disables the check for CR characters for all following lines in the file * `xfail-tidy-tab` - Disables the check for tab characters for all following lines in the file * `xfail-tidy-linelength` - Disables the line length check for all following lines in the file Checks should not have to be disabled often. I disabled line length checks in `debug-info` tests that use `debugger:` checks, but aside from that, there were relatively few exclusions. Running tidy on all the tests does slow down the formatting check, so it may be worth investigating further optimization. cc #4534
Extends the license and formatting check to `*.js` files in `src/doc` and `*.sh`, `*.pl`, `*.c`, and `*.h` files in `src/etc`. As best as I could tell, these files should be covered under the Rust project license. cc @brson: Do any other scripts need a license? I'd like to double-check that this PR closes #4534.
make tidy
checks the license of files but tidy is only run on a subset of the repository since some third party, tests and overlooked code isn't checked for formatting. We need to extend the tidy check to all source code, even tests (I think).The text was updated successfully, but these errors were encountered: