Skip to content

rustdoc: unions and consts are not color-coded #43523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
QuietMisdreavus opened this issue Jul 28, 2017 · 1 comment
Closed

rustdoc: unions and consts are not color-coded #43523

QuietMisdreavus opened this issue Jul 28, 2017 · 1 comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@QuietMisdreavus
Copy link
Member

All the various kinds of item in rust are given a color in rustdoc's CSS, but consts and unions never got one. Fixing should just be a matter of collecting the class name that these items use, and adding a couple rules to rustdoc.css to apply some color to them. The question of which color is another matter entirely. >_>
@QuietMisdreavus QuietMisdreavus added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. labels Jul 28, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 28, 2017
@GuillaumeGomez
Copy link
Member

I'll propose something out. :)

@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 30, 2017
Merged
bors added a commit that referenced this issue Aug 7, 2017
@bors
Auto merge of #43558 - GuillaumeGomez:union-const-colors, r=QuietMisd…
0188ec6 
…reavus

Union const colors

Fixes #43523

What do you think of these colors:

<img width="1440" alt="screen shot 2017-07-30 at 15 10 57" src="https://user-images.githubusercontent.com/3050060/28753752-6b175a22-7539-11e7-978e-949f3a947d18.png">

?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GuillaumeGomez @Mark-Simulacrum @QuietMisdreavus