Skip to content

Use include_bin! to include data set in test/bench/shootout-k-nucleotide #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue Jun 14, 2012 · 1 comment
Closed

Use include_bin! to include data set in test/bench/shootout-k-nucleotide #2598

catamorphism opened this issue Jun 14, 2012 · 1 comment
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

A FIXME indicates that that doesn't work right now.
@yichoi
Copy link
Contributor

yichoi commented Jul 2, 2013

suppose to be changed the title as "include_bin!" ?

@alexcrichton alexcrichton mentioned this issue Oct 14, 2013
Closed
bors added a commit that referenced this issue Oct 18, 2013
@bors
auto merge of #9851 : alexcrichton/rust/include_bin, r=huonw
d052912 
Previously an ExprLit was created *per byte* causing a huge increase in memory
bloat. This adds a new `lit_binary` to contain a literal of binary data, which
is currently only used by the include_bin! syntax extension. This massively
speeds up compilation times of the shootout-k-nucleotide-pipes test

    before:
        time: 469s
        memory: 6GB
        assertion failure in LLVM (section too large)

    after:
        time: 2.50s
        memory: 124MB

Closes #2598
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@adpaco-aws
Bump CBMC version to 5.87.0 (rust-lang#2598)
f26b1cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize include_bin! for large inputs alexcrichton/rust
2 participants
@catamorphism @yichoi