Skip to content

A few TODO remain in the code #17478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gamazeps opened this issue Sep 23, 2014 · 0 comments · Fixed by #17479
Closed

A few TODO remain in the code #17478

gamazeps opened this issue Sep 23, 2014 · 0 comments · Fixed by #17479

Comments

@gamazeps
Copy link
Contributor

It seems that the convention is now to use FIXME instead of TODO, yet there are still a few TODO left (can be found with grep) in src/etc, src/libbacktrace and src/rt
@gamazeps gamazeps mentioned this issue Sep 23, 2014
Merged
gamazeps added a commit to gamazeps/rust that referenced this issue Sep 29, 2014
@gamazeps
Replaced some TODO by FIXME
e543878 
closes rust-lang#17478
bors added a commit that referenced this issue Sep 30, 2014
@bors
auto merge of #17479 : gamazeps/rust/issue17478, r=alexcrichton
d7d954c 
closes #17478
bors added a commit that referenced this issue Sep 30, 2014
@bors
auto merge of #17479 : gamazeps/rust/issue17478, r=alexcrichton
88d1a22 
closes #17478
lnicola pushed a commit to lnicola/rust that referenced this issue Jul 11, 2024
@bors
Auto merge of rust-lang#17478 - kilpkonn:master, r=Veykril
4dd0ad7 
Simplify some term search tactics

Working on the paper `@phijor` found that "Data constructor" tactic could be simplified quite a bit by running it only in the backwards direction. With n+1 rounds it has same coverage as previous implementation in n rounds, however the tactic it self is more simple and also potentially faster as there is less to do.

In a nutshell the idea is to only work with types in the wish-list rather than with any types.

Turns out it is quite a bit faster:

Before:
```
ripgrep:
Tail Expr syntactic hits: 238/1692 (14%)
Tail Exprs found: 1223/1692 (72%)
Term search avg time: 15ms

nalgebra:
Tail Expr syntactic hits: 125/3001 (4%)
Tail Exprs found: 2143/3001 (71%)
Term search avg time: 849ms
```

After
````
ripgrep:
Tail Expr syntactic hits: 246/1692 (14%)
Tail Exprs found: 1209/1692 (71%)
Term search avg time: 8ms

nalgebra:
Tail Expr syntactic hits: 125/3001 (4%)
Tail Exprs found: 2028/3001 (67%)
Term search avg time: 305ms
````

_Also removed niche optimization of removing scope defs from the search space as this wasn't helping much anyway and made code a bit more complex._
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced some TODO by FIXME gamazeps/rust
1 participant
@gamazeps