-
Notifications
You must be signed in to change notification settings - Fork 13.4k
core::* listed four times in RUST_LOG=? #1531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Core is listed as an included crate for all other crates (in this case, |
This appears to be the same bug as #2673, but I'm not totally sure. |
This is still a bug. core does not appear at all now, but |
I think I can fix this. but as I know, the rust log system will be replaced with new one. |
Yes, I think it is worth fixing. Rewriting log is a low priority, and
|
Fixed in dd41f04 |
For now I just moved the reachability code to this new module. As a follow up PR, I am planning to move the unsized coercion related code into a separate module so it can be used to refactor and fix codegen casting logic (related issues rust-lang#1531, rust-lang#566, and rust-lang#1528) .
We currently have a few issues with how we are generating code for casting (rust-lang#566, and rust-lang#1528). The structure of the code is also hard to understand and maintain (see rust-lang#1531 for more details). This PR is the first part of the fix I developed. This change moves the coercion specific code to its own module and it introduces an iterator that traverses the coercion path.
Fix issues with how we are generating code for casting (rust-lang#566, and rust-lang#1528). Restructure the unsize casting to be done in one pass instead with deep recursion (rust-lang#1531). This also reuses the code from the reachability analysis, so we don't have to keep two ways of traversing the same structure.
The text was updated successfully, but these errors were encountered: