Skip to content

core::* listed four times in RUST_LOG=? #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdm opened this issue Jan 15, 2012 · 6 comments
Closed

core::* listed four times in RUST_LOG=? #1531

jdm opened this issue Jan 15, 2012 · 6 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@jdm
Copy link
Contributor

jdm commented Jan 15, 2012

Crate log map:

  core::u64
  core::uint
  core::int
  core::task
  core::str
  std::map::chained
  std::test
  std::ebml
  std::smallintmap
  std::getopts
  std::uv
  std::io
  core::u64
  core::uint
  core::int
  core::task
  core::str
  rustc::util::common
  rustc::middle::resolve
  rustc::back::rpath
  rustc::middle::trans_closure
  rustc::syntax::ext::fmt
  rustc::util::filesearch
  rustc::syntax::parse::lexer
  rustc::middle::fn_usage
  rustc::metadata::csearch
  rustc::middle::tstate::collect_locals
  rustc::middle::ty
  rustc::middle::tstate::bitvectors
  rustc::middle::tstate::pre_post_conditions
  rustc::syntax::parse::eval
  rustc::middle::typeck
  rustc::middle::debuginfo
  rustc::syntax::parse::parser
  rustc::front::attr
  rustc::middle::trans_build
  rustc::middle::tstate::ck
  rustc::middle::tstate::aux
  rustc::syntax::print::pp
  rustc::front::test
  rustc::metadata::cstore
  rustc::lib::llvm
  rustc::metadata::tydecode
  rustc::middle::tstate::annotate
  rustc::metadata::creader
  rustc::middle::trans
  rustc::driver::driver
  rustc::middle::ty::unify
  rustc::back::link
  core::u64
  core::uint
  core::int
  core::task
  core::str
  std::map::chained
  std::test
  std::ebml
  std::smallintmap
  std::getopts
  std::uv
  std::io
  core::u64
  core::uint
  core::int
  core::task
  core::str
@marijnh
Copy link
Contributor

marijnh commented Jan 25, 2012

Core is listed as an included crate for all other crates (in this case, rustc, librustc, and std). The runtime function that lists these should keep a set of visited crates and not descend already-visited ones. The same should probably be done in the function that updates logging flags.

@ghost ghost assigned graydon Apr 12, 2012
@catamorphism
Copy link
Contributor

This appears to be the same bug as #2673, but I'm not totally sure.

@catamorphism
Copy link
Contributor

This is still a bug. core does not appear at all now, but std::net_ip (for example) is listed four times.

@ILyoan
Copy link
Contributor

ILyoan commented Feb 8, 2013

I think I can fix this. but as I know, the rust log system will be replaced with new one.
Should this be fixed anyway?

@brson
Copy link
Contributor

brson commented Feb 8, 2013

Yes, I think it is worth fixing. Rewriting log is a low priority, and
hopefully the same fix can be used then as well.
On Feb 7, 2013 8:26 PM, "ILYONG CHO" [email protected] wrote:

I think I can fix this. but as I know, the rust log system will be
replaced with new one.
Should this be fixed anyway?


Reply to this email directly or view it on GitHubhttps://github.com//issues/1531#issuecomment-13276459.

ILyoan added a commit to ILyoan/rust that referenced this issue Feb 8, 2013
@ILyoan ILyoan mentioned this issue Feb 8, 2013
bors added a commit that referenced this issue Feb 8, 2013
@catamorphism
Copy link
Contributor

Fixed in dd41f04

@jdm jdm unassigned graydon Jun 16, 2014
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
For now I just moved the reachability code to this new module. As a follow up PR, I am planning to move the unsized coercion related code into a separate module so it can be used to refactor and fix codegen casting logic (related issues rust-lang#1531, rust-lang#566, and rust-lang#1528) .
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
We currently have a few issues with how we are generating code for casting (rust-lang#566, and rust-lang#1528). The structure of the code is also hard to understand and maintain (see rust-lang#1531 for more details).

This PR is the first part of the fix I developed. This change moves the coercion specific code to its own module and it introduces an iterator that traverses the coercion path.
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
Fix issues with how we are generating code for casting (rust-lang#566, and rust-lang#1528).

Restructure the unsize casting to be done in one pass instead with deep recursion (rust-lang#1531). This also reuses the code from the reachability analysis, so we don't have to keep two ways of traversing the same structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

6 participants