Skip to content

Rewrite std::rt::thread in Rust #10162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Oct 30, 2013 · 0 comments · Fixed by #10290
Closed

Rewrite std::rt::thread in Rust #10162

brson opened this issue Oct 30, 2013 · 0 comments · Fixed by #10290
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Oct 30, 2013

This currently delegates to the C++ rust_thread class, which is pretty simple. Add bindings to the native thread types and remove the C++ code.
@dbussink dbussink mentioned this issue Nov 5, 2013
Merged
bors added a commit that referenced this issue Nov 5, 2013
@bors
auto merge of #10290 : dbussink/rust/thread_in_rust, r=alexcrichton
7fb583b 
This binds to the appropriate pthreads_* and Windows specific functions
and calls them from Rust. This allows for removal of the C++ support
code for threads.

This needs to be reviewed for the Windows parts, I've tested on OS X and Linux.

Fixes #10162
@bors bors closed this as completed in 47e0bd4 Nov 5, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 12, 2023
@bors
Auto merge of rust-lang#10162 - tamaroning:fix10018, r=xFrednet
cf1d3d0 
Fix FP of single-element-loop

closes rust-lang#10018

---

changelog: [`single_element_loop`]: No longer lints, if the loop contains a `break` or `continue`
[rust-lang#10162](rust-lang/rust-clippy#10162)
<!-- changelog_checked -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move implementation for threads to Rust
1 participant
@brson