Skip to content

Log when a file is not served because it was too big #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2020
Merged

Log when a file is not served because it was too big #932

merged 1 commit into from
Aug 2, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Aug 2, 2020 •
edited
Loading

Found while working on #930.

Before:

2020/08/02 14:24:49 [DEBUG] cratesfyi::web: Path not found: /jni-android-sys/0.0.4/src/jni_android_sys/reference/api-level-28.rs.html; No such file or directory (os error 2)

After:

2020/08/02 14:35:55 [DEBUG] cratesfyi::web::rustdoc: got error serving rustdoc/jni-android-sys/0.0.4/src/jni_android_sys/reference/api-level-28.rs.html: the size limit for the buffer was reached
2020/08/02 14:25:52 [DEBUG] cratesfyi::web: Path not found: /jni-android-sys/0.0.4/src/jni_android_sys/reference/api-level-28.rs.html; No such file or directory (os error 2)

r? @pietroalbini

@jyn514 jyn514 added P-low Low priority issues S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed A-admin Area: Administration of the production docs.rs server labels Aug 2, 2020
Kixiron
Kixiron approved these changes Aug 2, 2020
View reviewed changes
Copy link
Member

@Kixiron Kixiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyn514 jyn514 merged commit efdfa75 into rust-lang:master Aug 2, 2020
@jyn514 jyn514 deleted the more-debugging branch August 2, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixiron Kixiron Kixiron approved these changes

Assignees
No one assigned
Labels
A-admin Area: Administration of the production docs.rs server P-low Low priority issues S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyn514 @Kixiron