Add minio container to mock s3 locally #597
Conversation
|
TODO:
Open questions:
|
docs.rs expects there to be a bucket 'rust-docs-rs', the minio Docker image does not provide a nice way to launch with a default bucket. As a workaround, we have to override the entrypoint to do some work before starting the minio server. When the minio server is launched with a directory that is not empty, it will interpret the directories present as buckets it needs to create. So by adding an empty directory 'rust-docs-rs', we can trick minio in creating a similarly named bucket. This solution is a mixture of the following comments: - minio/minio#4769 (comment) - minio/minio#4769 (comment)
You currently have it exposed. I kind of like this, I would find it very helpful for debugging.
That would make it harder to work on docs.rs without using docker ... Do you know if minio is easy to get set up on Windows? |
I would imagine you could also use Docker on Windows? |
|
Yes, but you can't run |
|
Since port 9000 is open, you could run But then we would also have to look at cleaning up the bucket after the tests have run... I think for now it is best to keep this code. If we find out no-one uses this fallback mechanism anymore we can clean it up. |
|
Wow, browsing s3 locally is super helpful. Thanks for working on this! |
|
Can you add instructions to the README for how to access this locally? Just 'navigate to localhost:9000` in your browser' is fine. |
Extends docker-compose.yml to also launch an container with minio, backed by a persistent volume.
Closes #463
It seems to work, but I can't test it reliably due this other issue I'm having right now: #594 (comment)