limits: allow overriding memory limits to more than 4GB #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, the overridden memory limits were stored as the allowed number of bytes in a 32-bit integer, which couldn't represent more than 4GB of RAM. This switches the database table to use a BIGINT (64-bit integer) as the column type, fixing the issue and allowing us to add big overrides.
This was referenced Jan 20, 2020
jyn514
reviewed
Jan 20, 2020
Co-Authored-By: Joshua Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, the overridden memory limits were stored as the allowed number of bytes in a 32-bit integer, which couldn't represent more than 4GB of RAM.
This switches the database table to use a BIGINT (64-bit integer) as the column type, fixing the issue and allowing us to add big overrides.
r? @jyn514