Skip to content

Link to docs for changing the build environment in issue templates #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 7, 2019

Addresses #504

The motivation here is to reduce the maintenance burder on the docs.rs team by having people submit PRs to https://github.com/rust-lang/crates-build-env directly. This has 2 main benefits:

  1. Crate authors already know the packages they need, so they don't have to tell us and have us make a PR ourselves; this removes an intermediate step.
  2. If crate authors are wrong about the packages they need (for instance, No Fortran compiler available #483 needed liblapack-dev, not just gfortran), they get immediate feedback instead of having to wait for a deploy and republish their package.

@jyn514
Copy link
Member Author

jyn514 commented Dec 7, 2019

Note that this only changes the issue templates, not the links on a failed page.

@pietroalbini pietroalbini self-assigned this Dec 7, 2019
@jyn514
Copy link
Member Author

jyn514 commented Dec 9, 2019

This is ready for review.

@pietroalbini
Copy link
Member

Thanks!

@pietroalbini pietroalbini merged commit 766e712 into rust-lang:master Dec 10, 2019
@jyn514 jyn514 deleted the build-env branch December 10, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants