Transform "documentation" tab into button

[GuillaumeGomez]

Same as before but with a fix for the 404 pages and a test to avoid regressions.

EDIT: Back to tab style but the "documentation" tab is now a button:

mobile:

"normal":

[jyn514]

Now that I think about this more, I'm not sure about this change ... it makes the /crate page very inconsistent with respect to the release pages, e.g. https://docs.rs/releases/stars.

[GuillaumeGomez]

It's voluntary and I proposed to discussed about it. Discussion is still open. :)

[pietroalbini]

Yeah, I think chasing the rustdoc styling for docs.rs is not the best choice, especially if we want to eventually make docs.rs in line with the website styling.

[GuillaumeGomez]

Agreed, that's why when we're still in "crate focus", we have a sidebar simply because the tab system is just not adapted. However, for the release pages, it totally makes sense (in my opinion).

[pietroalbini]

I'd keep everything that's not rustdoc with the same, consistent styling.

[GuillaumeGomez]

Except that the current tab style is not appropriate for the crate pages because the behavior of the tabs isn't consistent.

[pietroalbini]

I think having the button be more visible should help:

[pietroalbini]

Looks good! Two notes:

• Let's add some margin between the description and the button, to avoid having the ellipsis so close to the button itself.
• I'd add a bit more padding to the button (dunno, 10px 15px?).

[pietroalbini]

Also, it seems a bit off-centered.

[GuillaumeGomez]

Also, it seems a bit off-centered.

A bit more of precision on this one please. 😆 (I'll implement the other remarks in the meantime)

[pietroalbini]

I think the best solution to fix this is to put everything in a flexbox (not just the description) and have all the contents of the header on the left and the button on the right-

[pietroalbini]

Mostly looks good now! The only two changes I'd make:

• There are merge conflicts :)
• There should be some padding-bottom on mobile below the crate name, ideally the same as the padding-top. Currently it's too close to the tabs.

[GuillaumeGomez]

Done!

[jyn514]

I'm unsure about this change too :P I like making 'Documentation' a separate button, because it takes you to a whole new page. I don't like though that it's over on the right side of the screen - it's harder to find if you're looking in the old place and it's also away from the main focus, which is the crate title.

Maybe we could put it in the center instead (literally front and center ;)? Then it would be easier to find.

[GuillaumeGomez]

It's quite difficult to miss it though. But just by curiosity, where would you put it? (screenshot done with gimp please!)

[jyn514]

This changed the 'about' page to look rather strange, I think I prefered it before:

[GuillaumeGomez]

This changed the 'about' page to look rather strange, I think I prefered it before:

Then it's a bug! I'll fix it.

[jyn514]

About is fixed:

But releases are still broken:

We should really think about #996 :/

I'll review the rest in the meantime so you can fix bugs in parallel ;)

[GuillaumeGomez]

Fixed release page as well and fixed the nits.

We should really think about #996 :/

Yep but it's a tricky thing to do... We can use the same system we use in rustdoc but we still have the issue with getting the screenshot differences. But in here, I think this problem would be very limited considering that the build is quite small in comparison.

[jyn514]

Thanks for working on this!