Skip to content

New rustdoc member: jsha #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GuillaumeGomez
Copy link
Member

cc @rust-lang/rustdoc

And more precisely: cc @jsha

@GuillaumeGomez GuillaumeGomez requested a review from a team April 20, 2021 09:28
Manishearth
Manishearth previously approved these changes Apr 20, 2021
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording fixes

@GuillaumeGomez
Copy link
Member Author

Thanks for the wording improvements @Manishearth ! Updated.


Hello everyone, please welcome [Jacob Hoffman-Andrews][@jsha] to the rustdoc team!

Jacob Hoffman-Andrews([@jsha]) has been contributing a lot on rustdoc front-end. Thanks to him, the pageload of the rustdoc pages is much faster. Here is a non-exhaustive list of the stuff he's done recently:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Jacob Hoffman-Andrews([@jsha]) has been contributing a lot on rustdoc front-end. Thanks to him, the pageload of the rustdoc pages is much faster. Here is a non-exhaustive list of the stuff he's done recently:
Jacob Hoffman-Andrews ([@jsha]) has been contributing a lot on rustdoc front-end. Thanks to him, the pageload of the rustdoc pages is much faster. Here is a non-exhaustive list of the stuff he's done recently:

@GuillaumeGomez
Copy link
Member Author

I guess github is broken for the moment... Still can't see my last update. Well, we'll see at that moment. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants