Skip to content

N26: Add Emerald and Harvest Hero Origins #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 7, 2021
Merged

N26: Add Emerald and Harvest Hero Origins #787

merged 7 commits into from
Oct 7, 2021

Conversation

Bombfuse
Copy link
Contributor

@Bombfuse Bombfuse commented Oct 2, 2021

Adding Emerald updates and Harvest Hero Origins updates

Part of #783

@ozkriff ozkriff changed the title Add Emerald and Harvest Hero Origins N26: Add Emerald and Harvest Hero Origins Oct 3, 2021
@ozkriff ozkriff mentioned this pull request Oct 3, 2021
50 tasks
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! A couple of changes are required to confirm with CONTRIBUTING.md:

Write in third-person perspective.
Avoid having multiple/nested bullet points.
<...> image (<300kb) <...>

@Bombfuse
Copy link
Contributor Author

Bombfuse commented Oct 3, 2021

@ozkriff updated with the fixes

@ozkriff
Copy link
Member

ozkriff commented Oct 7, 2021

I've made some style fixes and other changes for consistency with the other newsletter sections - @Bombfuse are you ok with them?

@Bombfuse
Copy link
Contributor Author

Bombfuse commented Oct 7, 2021

looks good @ozkriff ! Made one small change because I just got Audio on web working, but it looks good to me now!

@ozkriff ozkriff merged commit c796eda into rust-gamedev:source Oct 7, 2021
@ozkriff
Copy link
Member

ozkriff commented Oct 7, 2021

Awesome! Merged! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants