Skip to content

N22: Nestadia #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2021
Merged

N22: Nestadia #644

merged 4 commits into from
Jun 4, 2021

Conversation

zer0x64
Copy link
Contributor

@zer0x64 zer0x64 commented Jun 2, 2021

_Part of #640

@zer0x64 zer0x64 marked this pull request as draft June 2, 2021 01:12
@zer0x64 zer0x64 force-pushed the source branch 2 times, most recently from 281aa40 to 7bd6484 Compare June 2, 2021 01:22
@zer0x64 zer0x64 marked this pull request as ready for review June 2, 2021 01:22
@zer0x64 zer0x64 marked this pull request as draft June 2, 2021 01:24
@zer0x64 zer0x64 marked this pull request as ready for review June 2, 2021 01:24
AngelOnFira
AngelOnFira requested changes Jun 2, 2021
View reviewed changes
Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great writeup 😄 a few changes needed, but otherwise this should be good 💯

@zer0x64
Copy link
Contributor Author

zer0x64 commented Jun 2, 2021

Sorry if the english is kinda broken at some places, it's my second language 🙃

I've fixed your comments and pushed them!

@AngelOnFira
Copy link
Member

Awesome, looks good 😄 There are a few linting issues, but I've submitted a PR to your fork with fixes for them.

zer0x64#1

@zer0x64
Copy link
Contributor Author

zer0x64 commented Jun 4, 2021

I just merged your PR!

@AngelOnFira AngelOnFira self-requested a review June 4, 2021 13:42
@AngelOnFira AngelOnFira merged commit d0535b3 into rust-gamedev:source Jun 4, 2021
@ozkriff ozkriff mentioned this pull request Jun 8, 2021
Closed
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AngelOnFira AngelOnFira AngelOnFira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zer0x64 @AngelOnFira