Add centered image captions using MD/CSS hack #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17cupsofcoffee
approved these changes
Sep 5, 2020
There was a problem hiding this comment.
LGTM!
You could potentially add the :first-child/:last-child thing to the non-linked variant as well, but I can't really think of a scenario where you'd have an image immediately followed by an em with the way that markdown renders paragraphs. Easy to add later on if needs be.
Also might be worth adding an example of how to add captions to the example entry in newsletter-template.md (or whatever file it is you use for the initial PR each month).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a MD/CSS hack to add centered image captions.
before/after imgs
Before:
After: