Skip to content

N42: Add Digital Extinction update (#1267) #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

Indy2222
Copy link
Contributor

@Indy2222 Indy2222 commented Feb 7, 2023

Part of #1267

@ozkriff
Copy link
Member

ozkriff commented Feb 7, 2023

image
(please, avoid mentioning the coordination issue in the commit itself - it causes additional noise in the issue due to how github works on every commit rebase. one mention in the PR's description is enough)

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please merge the first list item to avoid nesting? (CONTRIBUTING.md: "Avoid having multiple/nested bullet points. <...>")

Also, maybe it's worth adding an image to the top of the section? Like a screenshot from the video, for example.

image

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@ozkriff ozkriff merged commit df29d79 into rust-gamedev:source Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants