Skip to content

Add erupt content for newsletter 9 #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 2, 2020
Merged

Add erupt content for newsletter 9 #117

merged 4 commits into from
May 2, 2020

Conversation

Friz64
Copy link
Contributor

@Friz64 Friz64 commented May 1, 2020

Part of #111. This is a heavily compacted version of the erupt README.

ozkriff
ozkriff reviewed May 2, 2020
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erupt has a logo, right? it'd be cool to add it to the beginning of the section.

also, it'd be a good idea to add a short note of how erupt is different from other vulkan libs.

@Friz64
Copy link
Contributor Author

Friz64 commented May 2, 2020

Thank you for these suggestions, i implemented them. I wasn't sure what resolution the logo should have, i ended up with 128x128.

ozkriff
ozkriff approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌋

@ozkriff ozkriff merged commit f714e86 into rust-gamedev:source May 2, 2020
@ozkriff
Copy link
Member

ozkriff commented May 2, 2020

Merged, thanks for the PR!

@ozkriff ozkriff mentioned this pull request May 2, 2020
Closed
53 tasks
@Friz64 Friz64 deleted the friz-erupt-009 branch May 2, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Friz64 @ozkriff