Fix WithScope for destructured post arguments #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
vs/fix_with_scope_for_destructured_post_arguments
branch
from
d1d1790 to
0d565b0
Compare
kddnewton
requested changes
Jul 14, 2023
vinistock
force-pushed
the
vs/fix_with_scope_for_destructured_post_arguments
branch
from
0d565b0 to
fcc974a
Compare
kddnewton
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caught by one of YARP's fixtures. When you have
Then
postswill include aMLHSParen, which we need to account for inWithScopeand also in the typing annotations.