Skip to content
This repository was archived by the owner on Oct 19, 2018. It is now read-only.

merge access violation errors #75

Closed
catmando opened this issue Mar 6, 2018 · 1 comment
Closed

merge access violation errors #75

catmando opened this issue Mar 6, 2018 · 1 comment
Milestone

Comments

@catmando
Copy link
Contributor

catmando commented Mar 6, 2018

I see several different error classes across the gems, e.g. Hyperloop::AccessViolation and ReactiveRecord::AccessViolation. It would be useful if they all shared a parent class e.g. HyperloopError rather than inheriting from StandardError.

@catmando catmando added this to the Release 0.15 milestone Mar 6, 2018
@catmando
Copy link
Contributor Author

catmando commented Mar 6, 2018

Thanks ReactiveRecord::AccessViolation was deprecated long ago, but never removed from the code. Taking it out now. Given this I think its okay to continue having the single error Hyperloop::AccessViolation inherit from standard error? If not the issue needs to be on either the Hyperloop-config gem (since its the common base) or on Hyper-operation (since its where it comes from) closing this for now.

@catmando catmando closed this as completed Mar 6, 2018
catmando added a commit that referenced this issue Mar 6, 2018
sfcgeorge pushed a commit to joblabteam/hyper-mesh that referenced this issue Mar 6, 2018
catmando added a commit that referenced this issue Mar 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant