You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 19, 2018. It is now read-only.
I see several different error classes across the gems, e.g. Hyperloop::AccessViolation and ReactiveRecord::AccessViolation. It would be useful if they all shared a parent class e.g. HyperloopError rather than inheriting from StandardError.
The text was updated successfully, but these errors were encountered:
Thanks ReactiveRecord::AccessViolation was deprecated long ago, but never removed from the code. Taking it out now. Given this I think its okay to continue having the single error Hyperloop::AccessViolation inherit from standard error? If not the issue needs to be on either the Hyperloop-config gem (since its the common base) or on Hyper-operation (since its where it comes from) closing this for now.
I see several different error classes across the gems, e.g. Hyperloop::AccessViolation and ReactiveRecord::AccessViolation. It would be useful if they all shared a parent class e.g. HyperloopError rather than inheriting from StandardError.
The text was updated successfully, but these errors were encountered: